Yafaray4tS v0.9.0

LightWorks, VRay, Dribble, YafaRay and more..
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

No it's just cropped out.
Do we need to add a 'Set from Keyframe' button to the Anim aspect?
And or anything else?

Is it something I can do, or do you want what I have presently?
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 11 Jul 2018, 18:43 No it's just cropped out.
Do we need to add a 'Set from Keyframe' button to the Anim aspect?
And or anything else?

Is it something I can do, or do you want what I have presently?
Replace the "Set Timeline Range" button with the 2 buttons "Set from Timeline" and "Set from Keyframes".
I don't like the "Set Timeline Range" button because it changes truespace animation preferences when it should only be changing render preferences.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Okay here it is:
When testing RC -9 with Vray Loaded I discovered several issues.
I committed most of the changes and if you have any questions by all means ask.
I have used your PostReset code with some additional code and renamed it C3DReset
The ReadMe has been updated with new instructions, Prerequisites, additions, and renamed to YafaRay4tSv090 Installation Instructions.txt
I have included a WIP new YafaRay4tS Help.chm mostly adding the installation.htm and history.htm which is simular to the YafaRay4tSv090 Installation Instructions.txt
I think you will be able to figure out why some of the changes were neccessary by reading the instructions.
If you test this with Vray Loaded you will notice that Yafaray does not come in as the Offline Renderer.
That is because tS loads in alphabetical order. So to switch to Yafaray you need to change the Renderer and right click any of the Offline Render icons or the YafaRay Settings icon.
The YafaRay Export and Render icon was removed.
The YafaRay Settings icon's LMB does not do anything (Load the YafaRay4tS) if Vray is the Renderer until you change the Renderer to Yafaray. The RMB switches to Yafaray.
I changed the way the YafaRay toolbar loads by calling it from the library.

You mentioned that the YafarayScripts should be removed from the CustomStore with the Uninstall, that did not work out and causes problems with the C3DReset and Update 4. I did remove it from CustomCommands though.
Removed due to update
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

More checks before installation: make sure the plugin is installed, require that truespace has been reset at least one time in the past before installation.
top of YafaRay4tS_Installer/Install YafaRay4tSv0.9.0

Code: Select all

	try {
		var util = System.CreateDO("Clintons3D Package/Utility functions");
	} catch(e) {
		System.Alert("Error: Clintons3D Package must be installed and loaded first.");
		return;
	}

	if(!fsoFileExists(System.GetMainDir() + "\\Scripts\\reset.js")) {
		System.Alert("Error: Truespace must be restarted via context reset at least once before installation.");
		return;
	}
remove node delete near bottom which prevents "Integrated Button Install" from running

Code: Select all

		//Node.Delete(System.ThisOwner())
moved to the bottom of YafaRay4tS_Installer/Integrated Button Install

Code: Select all

	Node.Delete(System.ThisOwner());
Last edited by clintonman on 12 Jul 2018, 00:39, edited 1 time in total.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

I was getting an error.
Fixed it by adding a Var fso
putting a period between !fso FileExists
and changing System.GetMainDir() to mainDir

Code: Select all

	owner = System.ThisOwner();
	mainDir = System.GetMainDir();

	try {
		var util = System.CreateDO("Clintons3D Package/Utility functions");
	} catch(e) {
		System.Alert("Error: Clintons3D Package must be installed and loaded first.");
		return;
	}
	var fso = new ActiveXObject("Scripting.FileSystemObject");
	if(!fso.FileExists(mainDir + "\\Scripts\\reset.js")) {
		System.Alert("Error: trueSpace must be restarted via context reset at least once before installation.");
		return;
	}
I did not have a //Node.Delete(System.ThisOwner()) in the "Integrated Button Install script
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

Added a "Pre-install" node between "Reset Toolbars Install" and "Install YafaRay4tSv0.9.0" to be sure Scripts/CustomCommands exists.

Code: Select all

	mainDir = System.GetMainDir();

	var fso = new ActiveXObject("Scripting.FileSystemObject");
	if(!fso.FolderExists(mainDir + "\\Scripts\\clintonobjects"))
		return;

	if(Node.Exists("Scripts/ReloadCustomScripts"))
		Node.Delete("Scripts/ReloadCustomScripts");

	RsFileIO.LoadObject(System.GetMainDir() + '\\Scripts\\clintonobjects\\ReloadCustomScripts.RsObj', "Scripts");
	Activity.Run("Scripts/ReloadCustomScripts");
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

Changed C3DReset - was setting improper default values
YafaRay4tS_Installer/C3DReset

Code: Select all

		//Node.Value("/Yafaray Folder/YafaRay4tS", "useRenderToFile") = 0
		//Node.Value("/Yafaray Folder/YafaRay4tS", "useOptDetector") = 0
Removed same from the Yafaray4tS nodes reset button
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

line 56 added call to alter reset.js file so unpatched tS can recover from a context reset, uses the C3DReset

Code: Select all

		UpdateResetFile();
and at the end

Code: Select all

function UpdateResetFile()
{
	//trim polyfill
	if (!String.prototype.trim) {
  		String.prototype.trim = function () {
    		return this.replace(/^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g, '');
  		};
	}

	//RsFileIO.SaveObject(System.GetMainDir()+ '\\Scripts\\preobjects\\PostReset.RsObj', System.ThisOwner() + "/PostReset")

	var fso = new ActiveXObject("Scripting.FileSystemObject");

	//
	//edit reset.js file to call PostReset
	//
	var forReading = 1, forWriting = 2, forAppending = 8;
	var TristateUseDefault = -2, TristateTrue = -1, TristateFalse = 0; 

	if(postResetIsAlreadyDone()) {
		System.Trace("reset.js file already set for Context Reset processing. no changes made.");
		//Node.Delete(System.ThisOwner())
		return;
	}

	if(!fso.FileExists(System.GetMainDir() + "\\Scripts\\resetORIGINAL.js")) {
		fso.CopyFile(System.GetMainDir() + "\\Scripts\\reset.js", System.GetMainDir() + "\\Scripts\\resetORIGINAL.js", true);
	}

	var f = fso.GetFile(System.GetMainDir() + "\\Scripts\\reset.js");
	var connToFile = f.OpenAsTextStream( forReading, TristateUseDefault );
	var filecontents = connToFile.ReadAll();
	connToFile.Close();

	var fileArray = filecontents.split("\n");
	var execpostFound = false;

	//replace ScriptObject.Execute with Activity.Run because if it deletes itself it blocks others

	var reC3D = /ScriptObject\.Execute\("Project\/Space 3D\/C3DReset"\);/;
	var rePost = /ScriptObject\.Execute\("\/PostReset"\);/;

	for (var i = 0; i< fileArray.length;i++) {
		if(fileArray[i].match(rePost)) {
			System.Trace(fileArray[i]);
			fileArray[i] = 'Activity.Run("/PostReset");';
			execpostFound = true;
		}
		if(fileArray[i].match(reC3D)) {
			System.Trace(fileArray[i]);
			fileArray[i] = 'Activity.Run("Project/Space 3D/C3DReset");';
		}
	}

	connToFile = f.OpenAsTextStream( forWriting, TristateUseDefault );
	for(var j=0; j<fileArray.length; j++) {
		connToFile.WriteLine(fileArray[j].trim());
	}

	connToFile.Close();

	//if PostReset entry not found add it at the end of the file

	if(!execpostFound) {
		connToFile = f.OpenAsTextStream( forAppending, TristateUseDefault );
		connToFile.WriteLine("RsFileIO.LoadObject( rosDir + '\\\\scripts\\\\preObjects\\\\C3DReset.RsObj', '/');");
		connToFile.WriteLine('Activity.Run("/C3DReset");');
	}

	connToFile.Close();
	System.Trace("reset.js now set for Context Reset processing");
}

function postResetIsAlreadyDone()
{
	var fso = new ActiveXObject("Scripting.FileSystemObject");

	var forReading = 1, forWriting = 2, forAppending = 8;
	var TristateUseDefault = -2, TristateTrue = -1, TristateFalse = 0; 

	if(!fso.FileExists(System.GetMainDir()+ "\\Scripts\\reset.js"))
		return true;

	var f = fso.GetFile(System.GetMainDir() + "\\Scripts\\reset.js");

	if(!f) return true;

	var lines = [];

	var connToFile = f.OpenAsTextStream( forReading, TristateUseDefault );

	//var re = 'ScriptObject.Execute("/PostReset");';
	var re = 'Activity.Run("/C3DReset");';

	while (!connToFile.AtEndOfStream) {

		var curline = connToFile.ReadLine();
		if(curline == re) {
			connToFile.Close();
			return true;
		}
	}

	connToFile.Close();
	return false;
}
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

bugs Yafaray toolbar buttons:
Render scene, Render animation and Render object buttons do not work with unpatched truespace

camera button does not work - checking earlier posts now, thought that was fixed already

Edit: more info
/Scripts/Commands/RenderScene does not exists in unpatched truespace, same for /Scripts/Commands/RenderObject
animation button is set to run RenderObject instead of RenderAnimation

Code: Select all

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderScene');

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

clintonman wrote: 12 Jul 2018, 00:51 bugs Yafaray toolbar buttons:
Render scene, Render animation and Render object buttons do not work with unpatched truespace

camera button does not work - checking earlier posts now, thought that was fixed already

Edit: more info
/Scripts/Commands/RenderScene does not exists in unpatched truespace, same for /Scripts/Commands/RenderObject
animation button is set to run RenderObject instead of RenderAnimation

Code: Select all

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderScene');

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');
I'll put a if node exist for the Activity.Run for those and fix the RenderAnimation

Not sure what to do with the Yaf Camera widget
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 12 Jul 2018, 01:14
clintonman wrote: 12 Jul 2018, 00:51 bugs Yafaray toolbar buttons:
Render scene, Render animation and Render object buttons do not work with unpatched truespace

camera button does not work - checking earlier posts now, thought that was fixed already

Edit: more info
/Scripts/Commands/RenderScene does not exists in unpatched truespace, same for /Scripts/Commands/RenderObject
animation button is set to run RenderObject instead of RenderAnimation

Code: Select all

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderScene');

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');
I'll put a if node exist for the Activity.Run for those and fix the RenderAnimation

Not sure what to do with the Yaf Camera widget
Found problem with camera
name of file has lower case R - "YafaRay Camera" vs "Yafaray Camera"

Code: Select all

RsFileIO.LoadObject(tS + '\\Rs Main Libraries\\YafaRay4tS Setup\\YafaRay Camera.RsObj', "/Preferences/Cameras")
Edit: nope, that wasn't it. Truespace is being weird.

Edit: OK, think I found the real reason. Saved camera to preobjects - now survives context reset

Code: Select all

RsFileIO.SaveObject(tS + "\\Scripts\\preobjects\\Cameras.RsObj", "/Preferences/Cameras")
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

clintonman wrote: 12 Jul 2018, 01:19
trueBlue wrote: 12 Jul 2018, 01:14
clintonman wrote: 12 Jul 2018, 00:51 bugs Yafaray toolbar buttons:
Render scene, Render animation and Render object buttons do not work with unpatched truespace

camera button does not work - checking earlier posts now, thought that was fixed already

Edit: more info
/Scripts/Commands/RenderScene does not exists in unpatched truespace, same for /Scripts/Commands/RenderObject
animation button is set to run RenderObject instead of RenderAnimation

Code: Select all

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderScene');

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');

OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');
I'll put a if node exist for the Activity.Run for those and fix the RenderAnimation

Not sure what to do with the Yaf Camera widget
Found problem with camera
name of file has lower case R - "YafaRay Camera" vs "Yafaray Camera"

Code: Select all

RsFileIO.LoadObject(tS + '\\Rs Main Libraries\\YafaRay4tS Setup\\YafaRay Camera.RsObj', "/Preferences/Cameras")
Edit: nope, that wasn't it. Truespace is being weird.

Edit: OK, think I found the real reason. Saved camera to preobjects - now survives context reset

Code: Select all

RsFileIO.SaveObject(tS + "\\Scripts\\preobjects\\Cameras.RsObj", "/Preferences/Cameras")

Code: Select all

//WorkspaceMain
OfflineRender.OpenView('',0,0);OfflineRender.RenderScene('');Activity.Run('/Scripts/Commands/RenderScene')
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject')
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderAnimation');
RsTool.AddPrimitive('/Widgets/Tools/Primitives/Primitive tool','{B1D12AD1-47D4-4e6c-8227-DC80FF55D7BB}{A46795D3-0DE2-4ed8-9FB6-91D84FB9F1EB}(/Preferences/Cameras/Factory preferences){/Preferences/Lights/Preferences}','/Preferences/Cameras/Camera');
RsTool.AddPrimitive('/Widgets/Tools/Primitives/Primitive tool','{B1D12AD1-47D4-4e6c-8227-DC80FF55D7BB}{A46795D3-0DE2-4ed8-9FB6-91D84FB9F1EB}(/Preferences/Cameras/Factory preferences){/Preferences/Lights/Preferences}','/Preferences/Cameras/EntryPoint');

//WorkspaceMain2
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderScene');
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderAnimation');
RsTool.AddPrimitive('/Widgets/Tools/Primitives/Primitive tool','{B1D12AD1-47D4-4e6c-8227-DC80FF55D7BB}{A46795D3-0DE2-4ed8-9FB6-91D84FB9F1EB}(/Preferences/Cameras/Factory preferences){/Preferences/Lights/Preferences}','/Preferences/Cameras/Camera');

//Yafaray toolbar
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderScene')){OfflineRender.RenderScene('');Activity.Run('/Scripts/Commands/RenderScene');}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderObject')){Activity.Run('/Scripts/Commands/RenderObject');}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderAnimation')){Activity.Run('/Scripts/Commands/RenderAnimation');}
RsTool.AddPrimitive('/Widgets/Tools/Primitives/Primitive tool','{B1D12AD1-47D4-4e6c-8227-DC80FF55D7BB}{A46795D3-0DE2-4ed8-9FB6-91D84FB9F1EB}(/Preferences/Cameras/Factory preferences){/Preferences/Lights/Preferences}','/Preferences/Cameras/Yafaray Camera');
No change with the Yaf cam
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

Last set of changes

delete line added for camera to be like the lights load

Code: Select all

		Node.Delete("/Preferences/Cameras/Yafaray Camera")
		RsFileIO.LoadObject(tS + '\\Rs Main Libraries\\YafaRay4tS Setup\\Yafaray Camera.RsObj', "/Preferences/Cameras")
backup files for safety

Code: Select all

if(!fso.FileExists(System.GetMainDir() + "\\Scripts\\preobjects\\LightsORIGINAL.rsobj")) {
			fso.CopyFile(System.GetMainDir() + "\\Scripts\\preobjects\\Lights.rsobj", System.GetMainDir() + "\\Scripts\\preobjects\\LightsORIGINAL.rsobj", true);
		}
		if(!fso.FileExists(System.GetMainDir() + "\\Scripts\\preobjects\\CamerasORIGINAL.RsObj")) {
			fso.CopyFile(System.GetMainDir() + "\\Scripts\\preobjects\\Cameras.RsObj", System.GetMainDir() + "\\Scripts\\preobjects\\CamerasORIGINAL.RsObj", true);
		}
added to uninstall

Code: Select all

		Node.Delete("/Preferences/Cameras/Yafaray Camera")
		RsFileIO.SaveObject(tS + '\\Scripts\\preobjects\\Cameras.RsObj', "/Preferences/Cameras")
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

RC12 - works with unpatched truespace, render buttons in yafaray toolbar still broken
Requirements - plugin file, c3d persistent installed and a reset to default context has to be run before the installer will run. The reset default context creates the reset.js file, fresh install does not have that file.

TODO: test with patched/unofficial updated version
Attachments
YafaRay4tSv090-RC-12.zip
(6.82 MiB) Downloaded 161 times
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

I am getting lost after your last two code changes
I did find a typo with the camera in the install script

Code: Select all

//RsFileIO.LoadObject(tS + '\\Rs Main Libraries\\YafaRay4tS Setup\\YafaRay Camera.RsObj', "/Preferences/Cameras")
   RsFileIO.LoadObject(tS + '\\Rs Main Libraries\\YafaRay4tS Setup\\Yafaray Camera.RsObj', "/Preferences/Cameras")
//Add next line   		
   RsFileIO.SaveObject("/Preferences/Cameras", tS + '\\preobjects\\Cameras.RsObj')
Edit: Cross post
I'll fix the buttons
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 12 Jul 2018, 02:15 I am getting lost after your last two code changes
...
You can quote the confusing parts and I can try to answer.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

clintonman wrote: 12 Jul 2018, 02:46
trueBlue wrote: 12 Jul 2018, 02:15 I am getting lost after your last two code changes
...
You can quote the confusing parts and I can try to answer.
Wasn't sure which script you were referring too.
It's all good since you uploaded all the changes.
With regards to the yaf render buttons. Does these changes look right to you? Can you try them in the unpatched version?

Code: Select all

//WorkspaceMain Update 2
OfflineRender.OpenView('',0,0);OfflineRender.RenderScene('');Activity.Run('/Scripts/Commands/RenderScene')
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject')
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderAnimation');
RsTool.AddPrimitive('/Widgets/Tools/Primitives/Primitive tool','{B1D12AD1-47D4-4e6c-8227-DC80FF55D7BB}{A46795D3-0DE2-4ed8-9FB6-91D84FB9F1EB}(/Preferences/Cameras/Factory preferences){/Preferences/Lights/Preferences}','/Preferences/Cameras/Camera');

//WorkspaceMain2 Update 3 to present
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderScene');
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderAnimation');
RsTool.AddPrimitive('/Widgets/Tools/Primitives/Primitive tool','{B1D12AD1-47D4-4e6c-8227-DC80FF55D7BB}{A46795D3-0DE2-4ed8-9FB6-91D84FB9F1EB}(/Preferences/Cameras/Factory preferences){/Preferences/Lights/Preferences}','/Preferences/Cameras/Camera');

//Yafaray toolbar
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderScene')){Activity.Run('/Scripts/Commands/RenderScene');}if (!Node.Exists('/Scripts/Commands/RenderScene')){OfflineRender.RenderScene('');Activity.Run('/Scripts/Commands/RenderScene');}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderObject')){Activity.Run('/Scripts/Commands/RenderObject');}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderAnimation')){Activity.Run('/Scripts/Commands/RenderAnimation');}
Especially the yaf render scene. If they do not work, can you copy the original commands?
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 12 Jul 2018, 02:56
clintonman wrote: 12 Jul 2018, 02:46
trueBlue wrote: 12 Jul 2018, 02:15 I am getting lost after your last two code changes
...
You can quote the confusing parts and I can try to answer.
Wasn't sure which script you were referring too.
It's all good since you uploaded all the changes.
With regards to the yaf render buttons. Does these changes look right to you? Can you try them in the unpatched version?

Code: Select all

//WorkspaceMain Update 2
OfflineRender.OpenView('',0,0);OfflineRender.RenderScene('');Activity.Run('/Scripts/Commands/RenderScene')
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject')
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderAnimation');
RsTool.AddPrimitive('/Widgets/Tools/Primitives/Primitive tool','{B1D12AD1-47D4-4e6c-8227-DC80FF55D7BB}{A46795D3-0DE2-4ed8-9FB6-91D84FB9F1EB}(/Preferences/Cameras/Factory preferences){/Preferences/Lights/Preferences}','/Preferences/Cameras/Camera');

//WorkspaceMain2 Update 3 to present
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderScene');
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderObject');
OfflineRender.OpenView('',0,0);Activity.Run('/Scripts/Commands/RenderAnimation');
RsTool.AddPrimitive('/Widgets/Tools/Primitives/Primitive tool','{B1D12AD1-47D4-4e6c-8227-DC80FF55D7BB}{A46795D3-0DE2-4ed8-9FB6-91D84FB9F1EB}(/Preferences/Cameras/Factory preferences){/Preferences/Lights/Preferences}','/Preferences/Cameras/Camera');

//Yafaray toolbar
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderScene')){Activity.Run('/Scripts/Commands/RenderScene');}if (!Node.Exists('/Scripts/Commands/RenderScene')){OfflineRender.RenderScene('');Activity.Run('/Scripts/Commands/RenderScene');}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderObject')){Activity.Run('/Scripts/Commands/RenderObject');}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderAnimation')){Activity.Run('/Scripts/Commands/RenderAnimation');}
Especially the yaf render scene. If they do not work, can you copy the original commands?
ScriptsCommands.jpg
None of those will work, there is no '/Scripts/Commands/RenderScene' or any of the others.

unpatched render buttons:

Code: Select all

OfflineRender.OpenView('',0,0);OfflineRender.RenderScene('')

Widgets.ReplaceWidget('{88839603-7F98-41f0-96AC-BE94E801CFF3}','/Widgets/Tools/Offline render/Area scene render','Default','','dummy')

OfflineRender.OpenView('',0,0);OfflineRender.RenderObject('')

OfflineRender.OpenView('',0,0);OfflineRender.RenderAnimation('')
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Okay installed Rosetta without the Update, C3D persistent v2, Clintons3D Package, and YafaRay4tS.
These LMB commands work except the RenderAnimation but neither does Rosetta's RenderAnimation icon.
Render Animation buttons on the R2F and Anim aspect work.

Code: Select all

OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderScene')){Activity.Run('/Scripts/Commands/RenderScene');}if (!Node.Exists('/Scripts/Commands/RenderScene')){OfflineRender.RenderScene('')}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderObject')){Activity.Run('/Scripts/Commands/RenderObject');}if (!Node.Exists('/Scripts/Commands/RenderrObject')){OfflineRender.RenderRenderObject('')}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderAnimation')){Activity.Run('/Scripts/Commands/RenderAnimation');}if (!Node.Exists('/Scripts/Commands/RenderAnimation')){OfflineRender.RenderAnimation('')}

OfflineRender.OpenView('',0,0);OfflineRender.RenderAnimation('')
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 12 Jul 2018, 07:41 Okay installed Rosetta without the Update, C3D persistent v2, Clintons3D Package, and YafaRay4tS.
These LMB commands work except the RenderAnimation but neither does Rosetta's RenderAnimation icon.
Render Animation buttons on the R2F and Anim aspect work.

Code: Select all

OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderScene')){Activity.Run('/Scripts/Commands/RenderScene');}if (!Node.Exists('/Scripts/Commands/RenderScene')){OfflineRender.RenderScene('')}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderObject')){Activity.Run('/Scripts/Commands/RenderObject');}if (!Node.Exists('/Scripts/Commands/RenderrObject')){OfflineRender.RenderRenderObject('')}
OfflineRender.OpenView('',0,0);if (Node.Exists('/Scripts/Commands/RenderAnimation')){Activity.Run('/Scripts/Commands/RenderAnimation');}if (!Node.Exists('/Scripts/Commands/RenderAnimation')){OfflineRender.RenderAnimation('')}

OfflineRender.OpenView('',0,0);OfflineRender.RenderAnimation('')
You have a "2 renders" typo in object, ...OfflineRender.RenderRenderObject...
All other buttons including animation work in unpatch full truespace.
I will test unpatched rosetta now.
Tested same in unpatched rosetta, must have got animation and object button code mixed up in your testing.
Other than the typo it looks good to me.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Oh good. Moral of the Story...must not post in the dark.
First time trying iOptDetectors with Rosetta without Update and RC - 12
YafaRay4tS does not display the iOptDectector window, and status line shows Rendering...
If I go inside the tSDisplay, I can select Show Display and the last rendered image shows in the iOptDectector window. If I select the Open Bitmap View the iOptDectector window shows a White background even though you can see that the Bitmap in the BMPViewTransmitter is the last rendered image.
Capture.PNG
I have confirmed that the iOptDectector plugin and the BMPViewTransmitter are working outside of YafaRay4tS.


YafaRay4tS Animation is not working using Rosetta's Render Animation button.
When I select that icon the End Frame(13) is reset to the tS Timeline(126) in the Anim aspect.
And the Status Line shows Rendering...
Nothing is rendered
As mentioned the Render Animation button on the Anim aspect works.
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 12 Jul 2018, 15:14 Oh good. Moral of the Story...must not post in the dark.
First time trying iOptDetectors with Rosetta without Update and RC - 12
YafaRay4tS does not display the iOptDectector window, and status line shows Rendering...
If I go inside the tSDisplay, I can select Show Display and the last rendered image shows in the iOptDectector window. If I select the Open Bitmap View the iOptDectector window shows a White background even though you can see that the Bitmap in the BMPViewTransmitter is the last rendered image.
Capture.PNG
I have confirmed that the iOptDectector plugin and the BMPViewTransmitter are working outside of YafaRay4tS.


YafaRay4tS Animation is not working using Rosetta's Render Animation button.
When I select that icon the End Frame(13) is reset to the tS Timeline(126) in the Anim aspect.
And the Status Line shows Rendering...
Nothing is rendered
As mentioned the Render Animation button on the Anim aspect works.
Tried optdetector rosetta unpatched and it all works here. Opt window opens, shows each animation frame as it is rendered.
If you share your scene maybe I see if something else is happening.
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

Some things to fix:

set so opdetector is used by default only if it is installed - purely cosmetic change since code ignores it if it's not installed
YafaRay4tS/ResetToDefaults

Code: Select all

	if(typeof OptDetectors == 'undefined')
		Node.Value(Space.CurrentScene() + "/YafaRay4tS", "useOptDetector") = false;
animation defaults coming from the play range - should not be automatic unless start and end are the same values. this gives more control to the user to set their own range of values. when is automatic defaults should come from the AnimMng node values not the play range
Scripts/CustomCommands/YafarayScripts/RenderAnimation

Code: Select all

	if(Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Start_Frame") == Node.Value(Space.CurrentScene()+"/YafaRay4tS", "End_Frame")) {
		Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Start_Frame") = Node.Value("AnimMng", "AnimStart");
		Node.Value(Space.CurrentScene()+"/YafaRay4tS", "End_Frame") = Node.Value("AnimMng", "AnimEnd");
	}
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Here it is. Hope you can see what is wrong!
Feel free to make some improvements to anything you see in there. :D
Removed due to update
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 12 Jul 2018, 23:40 Here it is. Hope you can see what is wrong!
Feel free to make some improvements to anything you see in there. :D
Nope, it works here, it seems to be forcing the display on though, need to fix that.
Edit: Not a problem, forgot about the batch render option, which doesn't force the display.
With the weird problems you're having it may be time to restart your computer, truespace does have some kind of sticky memory at times.
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

I see something now. I opened the scene with patched full version of tS and see it not working.
I just tried a scene render.
It doesn't open the viewer and the status message is stuck "rendering..." but it does render.

One more thing on TODO list:
add to the bottom of YafaRay4tS/RenderFnSet - so render scene with no internal viewer will clear the status

Code: Select all

Activity.Run(Space.CurrentScene() + "/YafaRay4tS/ClearStatus");
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Hope you find out whats up.
1.) The Sequence Player's BitMap display Script on Right click has a double forward slash
SeQ Player.PNG
SeQ Player.PNG (1.75 KiB) Viewed 4492 times
2.) I think your Animation Rendering Status Line message is one frame to fast.
tS Animation Timeline is say on frame 9 (Rendering) and the Message says Frame # 9 Render Complete.
tS Animation Timeline moves to frame 10 and the Message says Frame # 10 Render Complete.
How do you render one keyframe? I do not think that is working either. Even setting the Start Frame to 14 and End Frame to 15 does not render as expected. IE: What I see in the Workspace view at frame 15.

3.) The message says Render # 1 Complete instead of Render # 14 Complete.

4.) When I select the Render Animation button in the above scenario there is no message that it is Rendering... In a long render time, it looks like nothing is happening.

5.) Think you should delete the Yaf_render.cmd after the Render is complete. Render to the Desktop from tS and YafaRay4tS and you will see why.

6.) Here is an example where I render from YafaRay4tS/Anim aspect Start Frame 17 and End Frame 17 to file name yaf_test.png in the first image. The second image is rendered from tS R2F Frame 17 to Frame 17 with the same name..
yaf_test_0000.png - Notice the differences in the naming of the rendered images on Frame 17?
yaf_test_0000.png
yaf_test_00017.png - Notice the differences in the images on Frame 17?
yaf_test_00017.png
7.) I do not think I wrote the Yafaray Settings RMB Command script right.
Do not think the YafaRay4tS node should be replaced if it Exist in the scene.

8.) Got an error using ts Render 2 File.
tS R2F error.PNG
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Here is all of the new YafaRay4tS buttons
Removed due to update
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

Found a bug in the texture system. When removing any texture the color texture was disabled in the preview. It still rendered ok, but turned white in the viewport.
Map/SwitchImage moved } furthur down so not resetting the "UseDiffuseMap" value
about 3 or 4 places in the code where it happens

Code: Select all

	//need to disconnect and reset con and delete self if switch to none MapType== -1
	if(MapType == -1) {
		Node.Disconnect(owner, "BitMapOUT", Node.Owner(owner) + "/ImagePreviewData", attributeName + "_img");
		Node.ConReset(Node.Owner(owner) + "/ImagePreviewData", attributeName + "_imgOUT");
		Node.ConReset(Node.Owner(owner) + "/ImagePreviewData", attributeName + "_img");

		//disconnect for diffuse_color - not working but delete will sever links
		if(Node.Exists(textureColorShader)) {
			if(attributeName == "diffuse_color") {
				Node.Disconnect(owner, "BlendOUT", textureColorShader, "DiffuseBlend")
				Node.Disconnect(owner, "DefColorOUT", textureColorShader, "DiffuseDefColor")
				Node.Disconnect(owner, "XOffsetOUT", textureColorShader, "OffsetU")
				Node.Disconnect(owner, "XScaleOUT", textureColorShader, "ScaleU")
				Node.Disconnect(owner, "YOffsetOUT", textureColorShader, "OffsetV")
				Node.Disconnect(owner, "YScaleOUT", textureColorShader, "ScaleV")
			//}

			Node.Value(textureColorShader, "UseDiffuseMap") = false;
			Node.Value(textureColorShader, "DiffuseMapType") = MapType;
			}
		}
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 13 Jul 2018, 05:28 Here is all of the new YafaRay4tS buttons

Does that include the bad "7.) I do not think I wrote the Yafaray Settings RMB Command script right.
Do not think the YafaRay4tS node should be replaced if it Exist in the scene."
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

ringVL.jpg
ring scene converted from virtualight scene. I wanted to try caustics and this is the scene I was working on when I discovered the texture map bug. The ring is black in the preview because it is mostly reflective and that doesn't translate well for the D3D viewport render. The wood in the render is too light It would match better with the texture gamma set to 2.2 instead of 1. Looks like the Map node got saved with gamma of 1, the reset value is 2.2

TODO: Map node gamma save at 2.2 gamma default in to the library

I'll plan to make a new RC release tomorrow.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

clintonman wrote: 13 Jul 2018, 05:38
trueBlue wrote: 13 Jul 2018, 05:28 Here is all of the new YafaRay4tS buttons

Does that include the bad "7.) I do not think I wrote the Yafaray Settings RMB Command script right.
Do not think the YafaRay4tS node should be replaced if it Exist in the scene."
The Yafaray Settings RMB Command node I was referring to resides inside the YafaRa4tS node.
The YafaRay4tS Settings icon's RMB calls the Yafaray Settings RMB Command node

Code: Select all

if (Node.Exists("/Yafaray Folder/YafaRay4tS")){Activity.Run("/Yafaray Folder/YafaRay4tS/Yafaray Settings RMB Command")}
Working on the Help file a little bit. Jack writes about YafaRay4tS:
"YafaRay4tS is implemented as an XML exporter that uses batch scripting to interface with YafaRay command line XML interface. This has a significant advantage over direct interfacing with the render engine allowing the user to continue to work on their project while YafaRay renders the spawned request in the background.
The YafaRay4tS user interface handles all these details of interfacing with the render engine transparently for the user so that they can focus on their art and not on setting the renderer up"
Is this true?
I minimized tS in the middle of rendering an animation at frame 15. When I opened it up it had stopped rendering at frame 15.

Is there anyway to stop changing or resetting the Output - Render File's image Width and Height after using the Render Portion? If not I was thinking about adding a script to it's widget.
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 13 Jul 2018, 06:30 ...

Working on the Help file a little bit. Jack writes about YafaRay4tS:
"YafaRay4tS is implemented as an XML exporter that uses batch scripting to interface with YafaRay command line XML interface. This has a significant advantage over direct interfacing with the render engine allowing the user to continue to work on their project while YafaRay renders the spawned request in the background.
The YafaRay4tS user interface handles all these details of interfacing with the render engine transparently for the user so that they can focus on their art and not on setting the renderer up"
Is this true?
I minimized tS in the middle of rendering an animation at frame 15. When I opened it up it had stopped rendering at frame 15.

Is there anyway to stop changing or resetting the Output - Render File's image Width and Height after using the Render Portion? If not I was thinking about adding a script to it's widget.
You have to choose the batch option to render in the background.

I don't know what he means by this: "The YafaRay4tS user interface handles all these details of interfacing with the render engine transparently [/color]for the user so that they can focus on their art and not on setting the renderer up"

I don't see Width and Height being reset anywhere. What are the steps to see this?
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

clintonman wrote: 13 Jul 2018, 13:56 I don't see Width and Height being reset anywhere. What are the steps to see this?
1.) In the Camera aspect, Render at 640x480.
2.) Next use the Render Portion. The Width and Height are changed in the Camera aspect.
3.) Exit Render Portion.
4.) Render again using the Render button

In Vray the Image - Width and Height does not change after using the Render Portion


With regards to what Jack wrote, can you give me a better example of what to write?
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 13 Jul 2018, 14:17
clintonman wrote: 13 Jul 2018, 13:56 I don't see Width and Height being reset anywhere. What are the steps to see this?
1.) In the Camera aspect, Render at 640x480.
2.) Next use the Render Portion. The Width and Height are changed in the Camera aspect.
3.) Exit Render Portion.
4.) Render again using the Render button

...
I don't see any way around that. Maybe add the ResX and ResY to the camera aspect so it's clear that the area render Xstart,Ystart,Width and Height is not the same as ResX ResY. Also if you uncheck Area Render it will use the ResX and ResY from the other panels.
The animation tab is also pointing to the area render attributes instead of ResX ResY.
Area render uses the full size information and the box within the full render to produce the area render result.

TODO:
add ResX, ResY to the camera aspect
change animation aspect to use ResX ResY instead of Yaf_Width and Yaf_Height
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Oh come on, I know you can do it. :D
Maybe create another node in YafaRa4tS that stores the current Width & Height.
Then after a Render, restore the previous stored Width & Height
If that is possible, no need to add any Area Render attributes in the user interface, unless for some reason it has value.

This probably is not right but maybe something like this in the RenderArea script:

Code: Select all

//Add to RenderArea script
var tmpYaf_Width = Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Yaf_Width")
var tmpYaf_Height = Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Yaf_Height")

Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Yaf_Width") = tmpYaf_Width
Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Yaf_Height") = tmpYaf_Height

		Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Yaf_Width") = dx * renderScale;
		Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Yaf_Height") = dy * renderScale;

// Add into End of RenderArea script
		Activity.Run(Space.CurrentScene()+"/YafaRay4tS/ExportXML");
		Activity.Run(Space.CurrentScene()+"/YafaRay4tS/Render");
		Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Yaf_Width") = tmpYaf_Width
		Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Yaf_Height") = tmpYaf_Height

Also can please explain to me why it is necessary to run the same script twice in two different locations, from the reset.js file?

Code: Select all

RsFileIO.LoadObject( rosDir + '\\scripts\\preObjects\\C3DReset.RsObj', scene);
Activity.Run("Project/Space 3D/C3DReset");
RsFileIO.LoadObject( rosDir + '\\scripts\\preObjects\\C3DReset.RsObj', '/');
Activity.Run("/C3DReset");
Whatever is decided I will be putting this in the unreleased Update 4.
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

RenderArea.jpg
diagram of how render area works
ResX, ResY used for the full render
StartX,y and Width and Height used for render area
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 13 Jul 2018, 19:18 ...

Also can please explain to me why it is necessary to run the same script twice in two different locations, from the reset.js file?

Code: Select all

RsFileIO.LoadObject( rosDir + '\\scripts\\preObjects\\C3DReset.RsObj', scene);
Activity.Run("Project/Space 3D/C3DReset");
RsFileIO.LoadObject( rosDir + '\\scripts\\preObjects\\C3DReset.RsObj', '/');
Activity.Run("/C3DReset");
Whatever is decided I will be putting this in the unreleased Update 4.
I can't explain why it's necessary because I don't think it is necessary.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

clintonman wrote: 13 Jul 2018, 19:45 I can't explain why it's necessary because I don't think it is necessary.
Well that explains it. :D
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

I got iOptDetector Viewer to work.
If I enable Internal Display Viewer it works.
If I disable Internal Display Viewer it does not work.

If I use the Rosetta RenderScene icon, I get this error:
Attachments
Capture.PNG
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

RC13
Lucky 13

changes/notes:

reset file alter so C3DReset is not run with ScriptObject.Execute - only issue for older test installer
also checks for Activity.Run("Project/Space 3D/C3DReset") pre-exist, does nothing if it does
also runs from scene instead of root to match unofficial update
RsFileIO.LoadObject( rosDir + '\\\\scripts\\\\preObjects\\\\C3DReset.RsObj', scene);
Activity.Run(scene + "/C3DReset");

replaced Width and Height on Animation panel to use ResX and ResY

added ResX and ResY to camera aspect, moving width and height to the area render section

Map node default gamma 2.2, fix bug where any texture removal erased the color texture preview

added new yafaray buttons from tB

animation tab script changed
Node.ConReset("%THIS_NAME%Sequence Player//Frame", "Frame")
to
Node.ConReset("%THIS_NAME%/Sequence Player/Frame", "Frame")

ShowDisplayFnSet anim status add start frame and subtract 1

6.) Here is an example where I render from YafaRay4tS/Anim aspect Start Frame 17 and End Frame 17
not possible to render a single frame animation because of the looping nodes
RenderAnim2 updated error message to check for less than 2 frame, was less than 1 before
also set numFrames to 2 instead of 1 because of the "off by one error"
var numFrames = end - start + 1;
if(numFrames < 2) {
Errors.Add("The End frame must be after the Start frame.");
numFrames = 2;
}

RenderFnSet at bottom clear status if internal view is false
Activity.Run(Space.CurrentScene() + "/YafaRay4tS/ClearStatus");

ResetToDefaults bottom - optdetector default adjustment
if(typeof OptDetectors == 'undefined')
Node.Value(yafNode, "useOptDetector") = false;

remove automatic frame range for animation unless start and end are the same frame in which case get start and end from the AnimMng node
Scripts/CustomCommands/YafarayScripts/RenderAnimation
if(Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Start_Frame") == Node.Value(Space.CurrentScene()+"/YafaRay4tS", "End_Frame")) {
Node.Value(Space.CurrentScene()+"/YafaRay4tS", "Start_Frame") = Node.Value("AnimMng", "AnimStart");
Node.Value(Space.CurrentScene()+"/YafaRay4tS", "End_Frame") = Node.Value("AnimMng", "AnimEnd");
}

Note: if tS not installed to "C:\trueSpace761" then auto load of Clintons3DPlugin.rsx will not occur when unofficial patch is installed

during install run full reset, not just 4 connectors
//Node.ConReset(Space.CurrentScene() + "/YafaRay4tS", "Yaf_Path")
//Node.ConReset(Space.CurrentScene() + "/YafaRay4tS", "Yaf_TempDir")
//Node.ConReset(Space.CurrentScene() + "/YafaRay4tS", "Yaf_XMLFilename")
//Node.ConReset(Space.CurrentScene() + "/YafaRay4tS", "Yaf_RenderFilename")
Activity.Run(Space.CurrentScene() + "/YafaRay4tS/ResetToDefaults")
Attachments
YafaRay4tSv090-RC-13.zip
(6.82 MiB) Downloaded 200 times
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Installed to Rosetta unpatched

Uncheck Render to File
1.) I'll repeat again, I do not understand why this would be a default setting.
Select the Save Settings button
Select Render button and I get this error:
First render.PNG
First render.PNG (9.44 KiB) Viewed 4291 times
Select the Output Render File C:\Temp\yaf_test.png (Default from RC-13)
2.) yaf_test.png is zero bytes (Noted that the yaf_temp.xml exist)
First render yaf_test png is 0 Bytes.PNG
First render yaf_test png is 0 Bytes.PNG (16.56 KiB) Viewed 4291 times
Select the Output Render File C:\Temp\yaf_test.jpg (Noted that the jpg was NOT zero bytes)

Select Render and I get the above error
Select the Output Render File C:\Temp\yaf_test.jpg (Noted that the jpg IS zero bytes)

I have reported this before. Any ideas what is wrong here?
Changed to:
Use Custom XML export file (Without using the File Dialog)
C:\Temp\CustomTemp.xml
This works, but now I do not see the CustomTemp.xml file in that path. (It was there previously)
If I uncheck Use Custom XML export file it does not work and the images are zero bytes again
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

trueBlue wrote: 14 Jul 2018, 04:23 I got iOptDetector Viewer to work.
If I enable Internal Display Viewer it works.
If I disable Internal Display Viewer it does not work.

If I use the Rosetta RenderScene icon, I get this error:
This is still true in RC-13
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

In the present released Update 4 reset.js file these 2 lines exist:

Code: Select all

RsFileIO.LoadObject( rosDir + "\\Scripts\\preobjects\\Yafaray Folder.RsObj", "/");
RsFileIO.LoadObject( rosDir + '\\Scripts\\clintonobjects\\ReloadCustomScripts.RsObj', "/Scripts");
RC-13 Does not remove these 2 lines
So as I understand it, this process is still being run twice!
I can remove these lines in the upcoming release but, for backwards compatibility I would suggest that you address this with your installation script.
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

RC - 13
Shows the Direct aspect after installation, instead of the Setup aspect like it did before.
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

RC -13
If I Unload OptDectectors Package and reboot Rosetta, Use Render to File Dialog is not honored with the Render buttons.
Render icons work as expected.
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

Still not seeing anything like that here:
rosetta not patched
install rsx plugin
install c3dpersistenceAutoload
reset context
install yaf4ts
uncheck render to file
save settings
render button - success

create c:\Temp
settings reset temp dir, reset custom xml, reset render output - done to try to match your setup
render button - success

I can't even begin to imagine why it's not working for you.

by default xml file is set to be delete after render

try the attached YafaRay4tS with the output console log view open and send me a screen shot

try deleting all the files in your temp folder

try deleting and recreating your temp folder

try rendering to a different location

try a different computer if possible

try disabling your anti virus software

what version of windows are you running? I've only tested on 2 win10 machines - win10 pro and win10 home

on a side note, C:\Temp isn't a part of windows. it's not included with winxp, win7 or win10. maybe it was left over from win98 or the original yaf4ts guys just made it up.
Attachments
YafaRay4tS58f8.RsObj
(794.19 KiB) Downloaded 175 times
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 15:27
trueBlue wrote: 14 Jul 2018, 04:23 I got iOptDetector Viewer to work.
If I enable Internal Display Viewer it works.
If I disable Internal Display Viewer it does not work.

If I use the Rosetta RenderScene icon, I get this error:
This is still true in RC-13
Is this 1 issue or 2 issues?
The error comes from disable internal viewer?

optdetector is an internal display, so it won't work if internal display is disabled
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 15:51 RC -13
If I Unload OptDectectors Package and reboot Rosetta, Use Render to File Dialog is not honored with the Render buttons.
Render icons work as expected.
The YafaRay4tS node render buttons are not set to use the render to file dialog. Only the toolbar buttons have that option.
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 15:44 RC - 13
Shows the Direct aspect after installation, instead of the Setup aspect like it did before.
roger that, will look for a fix
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 15:39 In the present released Update 4 reset.js file these 2 lines exist:

Code: Select all

RsFileIO.LoadObject( rosDir + "\\Scripts\\preobjects\\Yafaray Folder.RsObj", "/");
RsFileIO.LoadObject( rosDir + '\\Scripts\\clintonobjects\\ReloadCustomScripts.RsObj', "/Scripts");
RC-13 Does not remove these 2 lines
So as I understand it, this process is still being run twice!
I can remove these lines in the upcoming release but, for backwards compatibility I would suggest that you address this with your installation script.
OK, I see it. It doesn't hurt anything but I will alter the install to remove those lines.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

clintonman wrote: 14 Jul 2018, 16:11
trueBlue wrote: 14 Jul 2018, 15:27
trueBlue wrote: 14 Jul 2018, 04:23 I got iOptDetector Viewer to work.
If I enable Internal Display Viewer it works.
If I disable Internal Display Viewer it does not work.

If I use the Rosetta RenderScene icon, I get this error:
This is still true in RC-13
Is this 1 issue or 2 issues?
The error comes from disable internal viewer?

optdetector is an internal display, so it won't work if internal display is disabled
Tested again.
I am not getting an error this time using Rosetta icons.
If I enable Internal Display Viewer it works.
If I disable Internal Display Viewer it does not work.
New - If I use Rosetta Render Object nothing renders nor does Render to File if checked.
YafaRay Render icons work as expected
All of YafaRay4tS - Render buttons do not honor Use Render to File if checked
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

The YafaRay4tS node render buttons are not set to use the render to file dialog. Only the toolbar buttons have that option.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Got that. Crossed post!
Shouldn't the Render buttons honor that though?
Great work on the Render Area!
Well except for the panel editing. ;)
Not so sure of the value or use of exposing the Render Area attributes though.
Also suggest that you change the Render to File's Render Scene button to Render.
It is miss leading when you use the different Render icons and that is the way tS Render to File is.
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 16:51
New - If I use Rosetta Render Object nothing renders nor does Render to File if checked.
...
Not seeing this. Any steps to reproduce the problem?
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Think I found out what's up with the zero bytes issue
Attachments
Capture.PNG
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 17:06 ...
Shouldn't the Render buttons honor that though?
...
Nope.
trueBlue wrote: 14 Jul 2018, 17:06 ...
Well except for the panel editing. ;)
...
:P :lol:

trueBlue wrote: 14 Jul 2018, 17:06 ...
Also suggest that you change the Render to File's Render Scene button to Render.
...
will change
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 17:27 Think I found out what's up with the zero bytes issue
I can reproduce by setting photon mapping as the lighting method and reducing the photon counts to 5.

Now need to figure your xml file permissions problem.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

It is the Glass material (default settings) that is causing that error.
I repainted with Shiny Diffuse and now my image has some bytes :)
Also the xml file issue is not a problem now
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 17:49 It is the Glass material (default settings) that is causing that error.
I repainted with Shiny Diffuse and now my image has some bytes :)
Also the xml file issue is not a problem now
OK glad you figured it out.

The install not showing Setup aspect is solved
The renaming the Render Scene button is easy
Install removes those 2 redundant lines from the reset.js file

There is no way to get error messages from YafaRay renderer, so no way to automatically solve issues like the "not enough photons to render" issue.
May want to add a note to documentation that some errors can only be seen in the windows console.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Hummm… I do not remember the Glass material being an issue before.
The Render Object issue was my fault. Don't remember how but the Rosetta render icons were changed in my installation.

If you could apply XStart, YStart, Height, and Width to the Bounding Box of a selected object, you would have a perfect Render Object.
Attachments
RenderArea[1].jpg
RenderArea[1].jpg (11.14 KiB) Viewed 4125 times
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

RC14

The install shows the Setup aspect
Render Scene button relabeled to Render
Install removes 2 redundant lines from the reset.js file
Attachments
YafaRay4tSv090-RC-14.zip
(6.82 MiB) Downloaded 184 times
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

RC 14
Rosetta without update
Replaced Rosetta reset.js with Update 4 reset.js

1.) Export XML button status message does not clear
2.) Reset to Default Context does not work and never reopens Rosetta
Renaming the Backup does not work either
Delete all reset.js files and reset works
Reinstall RC 14 then reset works
IDK?
Access denial, IDK?
Your code to check for different version, IDK?

Conflict with iOptDetectors plugin wanting to reload it's libraries, IDK?
Note: I did install iOptDetectors to my C drive. Wanting to test if you can use different versions of tS.
Before I installed RC 14, I did notice that it never tried to load it's libraries until now.

There are differences in the way the reset.js files are being rewritten but mostly indents missing and spaces between lines.
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 22:23 RC 14
Rosetta without update
Replaced Rosetta reset.js with Update 4 reset.js

1.) Export XML button status message does not clear
2.) Reset to Default Context does not work and never reopens Rosetta
Renaming the Backup does not work either
Delete all reset.js files and reset works
Reinstall RC 14 then reset works
IDK?
Access denial, IDK?
Your code to check for different version, IDK?

Conflict with iOptDetectors plugin wanting to reload it's libraries, IDK?
Note: I did install iOptDetectors to my C drive. Wanting to test if you can use different versions of tS.
Before I installed RC 14, I did notice that it never tried to load it's libraries until now.

There are differences in the way the reset.js files are being rewritten but mostly indents missing and spaces between lines.
So you installed RC14 and then replaced the reset.js file with the Update 4 version? If so then maybe it looks for something that only exists in Update 4 and so it fails to restart.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

I replaced the Rosetta reset.js with the Update 4 reset.js file before installing RC-14 to test the new code.

Here is the Yafaray Folder from RC- 14 with modified panels Only.
Removed due to update
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 23:18 I replaced the Rosetta reset.js with the Update 4 reset.js file before installing RC-14 to test the new code.

Here is the Yafaray Folder from RC- 14 with modified panels Only.
In that case can you share the Update 4 reset.js file ?
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

You do know that the Rosetta reset.js file is different from tS761, right?
These versions are different then the released copies in that I changed to
Activity.Run("Project/Space 3D/C3DReset");
Here are both:


EDIT: Just notice an error in the Rosetta.log

Code: Select all

Error: Unspecified script error Line: 36, Char: 0 Script text:  RsFileIO.LoadObject( rosDir + '\\scripts\\preObjects\\Dialog settings.rsobj', '/Preferences/');    0x80020101  [RsScript.cpp(188)]
14:57:12.554 INFO  RsApp.RunScript('reset.js') - 1766 ms
and

Code: Select all

try {tSBridge.ConnectTSToSpace('/Project/Space 3D');} catch(exception) { } - 16 ms
This is was why Rosetta would not run the Reset to Default Context.
There was no Dialog settings.rsobj because this version was not updated.
Removed due to update
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 14 Jul 2018, 23:53 You do know that the Rosetta reset.js file is different from tS761, right?
These versions are different then the released copies in that I changed to
Activity.Run("Project/Space 3D/C3DReset");
Here are both:


EDIT: Just notice an error in the Rosetta.log

Code: Select all

Error: Unspecified script error Line: 36, Char: 0 Script text:  RsFileIO.LoadObject( rosDir + '\\scripts\\preObjects\\Dialog settings.rsobj', '/Preferences/');    0x80020101  [RsScript.cpp(188)]
14:57:12.554 INFO  RsApp.RunScript('reset.js') - 1766 ms
and

Code: Select all

try {tSBridge.ConnectTSToSpace('/Project/Space 3D');} catch(exception) { } - 16 ms
This is was why Rosetta would not run the Reset to Default Context.
There was no Dialog settings.rsobj because this version was not updated.
Got it and no, I only know what you decide to share.
So the take away is that the reset files from the updates should not be copied over the unpatched tS reset files.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

:oops:

I noticed in the C3DReset on line 41 does not work in Rosetta. That's because it is path dependent.
If you change that line with the following it will work with all versions of trueSpace

Code: Select all

WindowsManager.LoadLayout('\\default_layout.rsl');

Did you noticed that I shared a modified copy of the Yafaray Folder a few post back?
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 15 Jul 2018, 01:39 ...

Did you noticed that I shared a modified copy of the Yafaray Folder a few post back?
Yep, don't have it yet, but looking forward to it.
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

RC15

new panels
export xml clear status line
Attachments
YafaRay4tSv090-RC-15.zip
(6.82 MiB) Downloaded 200 times
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

The documentation looks good. here are some notes:

YafaRay4tS Toolbar page:
remove YafaRay Export and Render
at bottom Restore the toolbar - right click render icons

YafaRay4tS - Default page:
Input Color Space - LinearRGB, sRGB, XYZ - not sure what these do, XYZ is "experimental"
Clay Render - override all materials with a white diffuse material
Normals Smoothing - apply Blender style smoothing to a mesh, everything is hard edged by default in the YafaRay renderer
Reset Default Settings - resets all attributes
Render Pass Panel - opens a popup window of the Render Pass Panel
Denoise Settings - Mix=proportion of denoise and original image, Luminance=brightness noise control, Chrominance=color noise control, do not combine denoise with the Save Timer
Custom String - appears in the log files created by the Draw Parameter
Draw Parameter - logs render results to an html file
Tile Size - size of the boxes used for rendering
Tile Order - centre=build image from the center, random, linear=build image from top to bottom, tile order can be observed by using the Save Time option
Save Time - number of seconds between partial render saves, can be used to observe a long render to see if things are going well. Results during the render can be seen in Windows Explorer and in the optional OpDetector internal viewer. Set to zero to disable. Do not set too low because your machine may not be able to save quickly enough.
Render Object Mode - first dot standard mode, second dot experimental mode
Scene Brightness - used to alter D3D light attenuation to match YafaRay renders

Open Temp Folder - opens the folder containing the xml and command files. Renders will go to the same place by default.
Render - immediate render of the scene

YafaRay4tS - Background
Background type None will export as medium gray color and will remove any background previews generated.
Transparent - render background as transparent
Materials Transparent Refraction - materials refract the transparent background. Transparent background must be selected for this option to work.
Preview button - makes a D3D preview of the background by creating a large sphere and lights if "Use IBL" is active. The sphere and lights exists inside the YafaRay4tS node and are not exported.
Preview scale controls the size of the preview sphere.
remove this line from the Use IBL section - Use background on the "Default" tab must also be checked.
Sun Sky section buttons - "Select"=select the light inside the YafaRay node used to represent the sun. It can be moved but not rotated. It always points to the center of the scene. "# To Sun"=transfer the Sun direction numbers to the position of the preview sun light. "#From Sun"=transfer the sun light position from the preview light to the Sun Direction settings for export. The preview position is not exported.
Fog section remove - Requires Yafaray version 0.1.2 be setup with YafaRay4tSv0.7.5 and the "Yafaray 0.1.2 xml format - beta" checkbox enabled, located in the Setup aspect.

YafaRay4tS - Setup
Leave console open after render is only way to see warnings or errors from the YafaRay renderer.
Use OptDetector Viewer - overrides the default internal viewer in favor of the optional OptDetector Viewer.
remove the Yafaray 0.1.2 xml format - beta notes
File Format - png is the default format. Additional formats are exr, hdr, jpeg, png and tif. Tif files cannot be viewed inside of trueSpace. <- also change for each of the lighting model pages

Looks like the light pages have broken image links

materials - move texture attributes to a new texture mapping page
glossy material image is old
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

new bug found - if use Save timer with the internal viewer the status line does not clear. the internal viewer is not compatible with the save timer so that could be a factor.
don't know if this is is also true with the optdetector viewer - need to test
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

OMG! Last night I found out why I was having so many problems with Rosetta.
In the Task Manager, I had 3 Standalone Runners running, even without having any versions of tS open!

Yeah that YafaRay4tS Help file is messed up!
HTML Help Workshop does not have HTML editor, it's like using Notepad to edit HTML. Ugh!
Thanks for the additional info, that will help a lot!
I have found an easier way to create this help file.
I started using Word 2013 and I was pleasantly surprised that I can compile it using HTML Help Workshop.
All of the images of the panels etc... are now up to date.
I still need more info from you and I will get back to you ASAP.

I found some issues with the panels not updating on change, so I fixed that.
And I was able to modify the OptDetector Viewer's Window Frame by adding a toolbar and code to size the viewer by the values entered into the Width and Height. Turns out it was a rather small change to your Show Display and ShowDisplayFnSet scripts by adding:

Code: Select all

var Width = Node.Value(Space.CurrentScene() + "/YafaRay4tS", "Yaf_ResX")
var Height = Node.Value(Space.CurrentScene() + "/YafaRay4tS", "Yaf_ResY")
WindowsManager.MoveWindow("/Project/Windows Manager Space/Frame Window, 1", -1, -1, Width, Height, -1, -1, -1)
Node.Value("/Project/Windows Manager Space/Frame Window, 1", "TabsAsButtons") = -1
Node.Value("/Project/Windows Manager Space/Frame Window, 1", "Title") = Node.ShortName(Space.CurrentScene())
Node.Copy(Space.CurrentScene() + "/YafaRay4tS/tSDisplay/YafaRay4tS_ToolbarFrame", "/Project/Windows Manager Space/Frame Window, 1")
WindowsManager.Activate();
WindowsManager.UpdateWindowsStructure();
Capture.PNG
The toolbar icon needs a LMB command to save the image.
Here is the Yafaray Folder
Removed due to update
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

Sounds good.
"The toolbar icon needs a LMB command to save the image." - why is that? It already renders to a file.
What happens if you render an image larger than the screen dimensions and is that a problem?
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

I was thinking that you could use that command that use to be on the Display viewer.
tS Save As dialog ?
Would something like this work?

Code: Select all

Activity.Run(Space.CurrentScene() + "/YafaRay4tS/GetRenderFile");
Vray has Render to File on it's viewer.
Vray.SaveToFile('')
Vray R2F.PNG
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 15 Jul 2018, 18:09 I was thinking that you could use that command that use to be on the Display viewer.
tS Save As dialog ?
Would something like this work?

Code: Select all

Activity.Run(Space.CurrentScene() + "/YafaRay4tS/GetRenderFile");
Vray has Render to File on it's viewer.
Vray.SaveToFile('')
Vray R2F.PNG
This is the code that was directly on the button on the Display node
YafaRay4tS/tSDisplay/Display

Code: Select all

Library2.DlgGenericSave("","%THIS_NAME%",3);
Vray renders to memory, so it has to have a save to file button. YafaRay renders to a file already.
If you add a button to the optDisplay you may as well add it to the default intenal viewer too.
Clinton Reese

http://clintons3d.com
User avatar
trueBlue
Captain
Posts: 5548
Joined: 06 Jul 2009, 22:50
Type the number ten into the box: 10

Re: Yafaray4tS v0.9.0

Post by trueBlue »

Not sure how your Convert Format works with the BMPTransmitter.
I was thinking about doing something like this:
Capture.PNG
Which is just a copy of your Convert Format renamed to Image.
That way it shows in the dialog as an Image
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 15 Jul 2018, 19:20 Not sure how your Convert Format works with the BMPTransmitter.
I was thinking about doing something like this:
Capture.PNG
Which is just a copy of your Convert Format renamed to Image.
That way it shows in the dialog as an Image
This statement is unconfirmed and from memory:
I think you want to place it before the Convert Format. The BMP Transmitter is limited to 8 bit formats so it couldn't read exr or hdr renders. If you place it after you won't be able to save exr or hdr images.

Also be aware that YafaRay can render tif files which trueSpace can't read or write.
Clinton Reese

http://clintons3d.com
User avatar
clintonman
Captain
Posts: 5659
Joined: 21 May 2009, 21:08
Type the number ten into the box: 0
Location: California

Re: Yafaray4tS v0.9.0

Post by clintonman »

trueBlue wrote: 15 Jul 2018, 17:18 ...
I found some issues with the panels not updating on change, so I fixed that.
And I was able to modify the OptDetector Viewer's Window Frame by adding a toolbar and code to size the viewer by the values entered into the Width and Height. Turns out it was a rather small change to your Show Display and ShowDisplayFnSet scripts by adding:

Code: Select all

var Width = Node.Value(Space.CurrentScene() + "/YafaRay4tS", "Yaf_ResX")
var Height = Node.Value(Space.CurrentScene() + "/YafaRay4tS", "Yaf_ResY")
WindowsManager.MoveWindow("/Project/Windows Manager Space/Frame Window, 1", -1, -1, Width, Height, -1, -1, -1)
Node.Value("/Project/Windows Manager Space/Frame Window, 1", "TabsAsButtons") = -1
Node.Value("/Project/Windows Manager Space/Frame Window, 1", "Title") = Node.ShortName(Space.CurrentScene())
Node.Copy(Space.CurrentScene() + "/YafaRay4tS/tSDisplay/YafaRay4tS_ToolbarFrame", "/Project/Windows Manager Space/Frame Window, 1")
WindowsManager.Activate();
WindowsManager.UpdateWindowsStructure();
Capture.PNG
...
If the OptDisplay is already open it will not change size.
If a floating window(3dview, scene view, animation view...) is open it will change size.

Problems most likely caused by hard coded window name:
"/Project/Windows Manager Space/Frame Window, 1"

Tested with 4k resolution render, 3840 x 2160, and window limited itself to the size of the screen. So it didn't break anything.
Clinton Reese

http://clintons3d.com

Return to “Rendering”